-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
完善插件管理器的消息处理机制并启用多个插件 #1382
base: refactoring-v3-mvp
Are you sure you want to change the base?
完善插件管理器的消息处理机制并启用多个插件 #1382
Conversation
添加 SUCCESS 和 FAILED 的情况 {"result": "SUCCESS", "message": [], "voice": [], "image": []} {"result": "FAILED", "message": ["\u6ca1\u6709\u66f4\u591a\u4e86\uff01"], "voice": [], "image": []}
如: [sdwebui.alwayson_scripts.ADetailer] args = [{ad_model = "face_yolov8n.pt"},{ad_model = "hand_yolov8n.pt"}]
…toring-v3-mvp # Conflicts: # bot.py # config.py # conversation.py # drawing/sdwebui.py # manager/ratelimit.py # middlewares/draw_ratelimit.py # middlewares/ratelimit.py # platforms/http_service.py # requirements.txt # universal.py # utils/text_to_img.py
主要变更: 1. 新增 llms 配置部分,添加 OpenAI 后端配置 - 支持自定义 API 密钥、基础URL和模型 - 默认配置使用 claude-3.5-sonnet 模型 2. 更新插件配置,启用以下插件: - onebot_adapter - openai_adapter - workflow_plugin - prompt_generator - image_generator - music_player - weather_query
🧙 Sourcery 已完成对您的拉取请求的审查! 提示和命令与 Sourcery 交互
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in English🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @chuanSir123 - 我已经审查了您的更改 - 以下是一些反馈:
整体评论:
- 音乐播放器插件应该添加更强大的URL验证和错误处理,以防止处理无效或格式错误的URL时可能出现的运行时问题。
以下是我在审查期间查看的内容
- 🟡 一般性问题:发现2个问题
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进您的评论。
Original comment in English
Hey @chuanSir123 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The music player plugin should add more robust URL validation and error handling for failed requests to prevent potential runtime issues when dealing with invalid or malformed URLs.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|voice| String[] |音频返回,支持多个音频的base64编码;参考:data:audio/mpeg;base64,,iVBORw0KGgoAAAANS...| | ||
|image| String[] |图片返回,支持多个图片的base64编码;参考:data:image/png;base64,UhEUgAAAgAAAAIACAIA...| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议: Base64示例似乎被截断。
Base64的语音和图像示例似乎被截断。请完成这些示例或指明它们是占位符。
|voice| String[] |音频返回,支持多个音频的base64编码;参考:data:audio/mpeg;base64,,iVBORw0KGgoAAAANS...| | |
|image| String[] |图片返回,支持多个图片的base64编码;参考:data:image/png;base64,UhEUgAAAgAAAAIACAIA...| | |
|voice| String[] |音频返回,支持多个音频的base64编码;参考:data:audio/mpeg;base64,<base64_encoded_audio_data>| | |
|image| String[] |图片返回,支持多个图片的base64编码;参考:data:image/png;base64,<base64_encoded_image_data>| |
Original comment in English
suggestion: Base64 examples seem truncated.
The base64 examples for voice and image appear truncated. Please complete these examples or indicate that they are placeholders.
|voice| String[] |音频返回,支持多个音频的base64编码;参考:data:audio/mpeg;base64,,iVBORw0KGgoAAAANS...| | |
|image| String[] |图片返回,支持多个图片的base64编码;参考:data:image/png;base64,UhEUgAAAgAAAAIACAIA...| | |
|voice| String[] |音频返回,支持多个音频的base64编码;参考:data:audio/mpeg;base64,<base64_encoded_audio_data>| | |
|image| String[] |图片返回,支持多个图片的base64编码;参考:data:image/png;base64,<base64_encoded_image_data>| |
@@ -214,8 +214,8 @@ debug = false | |||
|:---|:---|:---| | |||
|result| String |SUCESS,DONE,FAILED| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
问题(拼写错误): 拼写错误:SUCESS 应该是 SUCCESS。
|result| String |SUCESS,DONE,FAILED| | |
|result| String |SUCCESS,DONE,FAILED| |
Original comment in English
issue (typo): Typo: SUCESS should be SUCCESS.
|result| String |SUCESS,DONE,FAILED| | |
|result| String |SUCCESS,DONE,FAILED| |
…p' into refactoring-v3-mvp # Conflicts: # framework/im/manager.py
主要更新:
Summary by Sourcery
实现对多个插件的支持并改进插件管理器的消息处理机制。
新功能:
Original summary in English
Summary by Sourcery
Implement support for multiple plugins and improve the message handling mechanism of the plugin manager.
New Features: